add new dimensions for ipad 11" screenshots support #22036
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validci/circleci
builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)Motivation and Context
This change was necessary for to add support to dimensions of screenshots that are supported by Apple appstore connect for ipad 11' screenshots
Resolves #21764
Description
I was running into errors:
According to https://developer.apple.com/help/app-store-connect/reference/screenshot-specifications/, the screen size "2360x1640" is actually supported by Apple but currently not being supported with fastlane. So I updated deliver/lib/deliver/app_screenshot.rb to include the supported dimensions that are missing.