Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(locale): normalize finance data #2915

Merged
merged 3 commits into from
May 25, 2024

Conversation

xDivisionByZerox
Copy link
Member

Description

Follow-on to #2265

Normalize the entries in the finance module definitions in all locales.

All changes made to locale file are sorting only.

@xDivisionByZerox xDivisionByZerox added p: 1-normal Nothing urgent c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs c: locale Permutes locale definitions m: finance Something is referring to the finance module labels May 19, 2024
@xDivisionByZerox xDivisionByZerox requested a review from a team as a code owner May 19, 2024 14:38
@xDivisionByZerox xDivisionByZerox self-assigned this May 19, 2024
Copy link

netlify bot commented May 19, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 157e71e
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/66524122541aab0008f93714
😎 Deploy Preview https://deploy-preview-2915.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@xDivisionByZerox xDivisionByZerox added this to the vAnytime milestone May 19, 2024
@xDivisionByZerox xDivisionByZerox requested a review from a team May 19, 2024 14:39
Copy link

codecov bot commented May 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.95%. Comparing base (a60f097) to head (157e71e).

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2915      +/-   ##
==========================================
+ Coverage   99.94%   99.95%   +0.01%     
==========================================
  Files        2977     2977              
  Lines      215421   215421              
  Branches      591      599       +8     
==========================================
+ Hits       215298   215333      +35     
+ Misses        123       88      -35     
Files Coverage Δ
src/locales/el/finance/account_type.ts 100.00% <100.00%> (ø)
src/locales/el/finance/credit_card/discover.ts 100.00% <100.00%> (ø)
src/locales/el/finance/credit_card/mastercard.ts 100.00% <100.00%> (ø)
src/locales/el/finance/transaction_type.ts 100.00% <100.00%> (ø)
src/locales/en/finance/account_type.ts 100.00% <100.00%> (ø)
src/locales/en/finance/credit_card/discover.ts 100.00% <100.00%> (ø)
src/locales/en/finance/credit_card/mastercard.ts 100.00% <100.00%> (ø)
src/locales/en/finance/transaction_type.ts 100.00% <100.00%> (ø)
src/locales/fa/finance/account_type.ts 100.00% <100.00%> (ø)
src/locales/fa/finance/credit_card/mastercard.ts 100.00% <100.00%> (ø)
... and 11 more

... and 2 files with indirect coverage changes

@ST-DDT ST-DDT requested a review from a team May 19, 2024 15:29
@ST-DDT ST-DDT enabled auto-merge (squash) May 25, 2024 19:51
@ST-DDT ST-DDT merged commit 353e85c into next May 25, 2024
20 checks passed
@ST-DDT ST-DDT deleted the refactor/locale/normalize-finance-data branch May 25, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: finance Something is referring to the finance module p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants