Add enableNativeProcessing() flag for Fabric ViewConfig attributes
#29039
+35
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickGerleman
changed the title
useNativeProcessing() flag for Fabric ViewConfigsuseNativeProcessing flag for Fabric ViewConfigs
|
Comparing: 6ef0dd4...1e055d0 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
We want to move more of the style parsing boundary into the Fabric renderer, instead of the outputs of the JavaScript preprocessing functions used by Paper. When using Fabric renderer, we will now check for the presence of a `useNativeProcessing` function, which we can wire with arbitrary granularity inside of RN to allow incrementally removing viewconfig processors when using Fabric.
NickGerleman
force-pushed
the
use-native-processing
branch
from
27471cb
to
42b0191
Compare
NickGerleman
changed the title
useNativeProcessing flag for Fabric ViewConfigsuseNativeProcessing flag for Fabric ViewConfig attributes
dmytrorykun
requested changes
May 10, 2024
packages/react-native-renderer/src/ReactNativeAttributePayloadFabric.js
Outdated
Show resolved
Hide resolved
dmytrorykun
approved these changes
May 10, 2024
NickGerleman
changed the title
useNativeProcessing flag for Fabric ViewConfig attributesenableNativeProcessing() flag for Fabric ViewConfig attributes
rickhanlonii
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We want to move more of the style parsing boundary into the Fabric renderer, instead of the outputs of the JavaScript preprocessing functions used by Paper.
When using Fabric renderer specifically, we will now check for the presence of a
useNativeProcessingfunction, which we can wire with arbitrary granularity inside of RN to allow incrementally removing viewconfig processors when using Fabric.How did you test this change?
Just flow, and existing tests, for this part of the change. The intention is to wire this function to feature flags on the RN side of the boundary, for specific views/attributes.