Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sign): add support for external ssh signing #2233

Closed
wants to merge 5 commits into from

Conversation

b1nhack
Copy link

@b1nhack b1nhack commented May 17, 2024

This Pull Request fixes/closes #2188, #2198.

It changes the following:

  • Adds support for external bin signing with ssh keys

I followed the checklist:

  • I added unittests
  • I ran make check

thread 'tests::test_pre_commit_py' panicked at git2-hooks/src/lib.rs:471:9:
assertion failed: res.is_ok()

  • I tested the overall application
  • I added an appropriate item to the changelog

@extrawurst
Copy link
Owner

since this basically undos the way ssh signing worked since 945ec45 i assume we can cleanup some of the now not used dependencies?

@b1nhack
Copy link
Author

b1nhack commented May 20, 2024

Okay, I'll check the code and try to make more optimizations.

@b1nhack
Copy link
Author

b1nhack commented May 22, 2024

No unused dependencies, but did some other code cleanup, fixed a test.

@b1nhack b1nhack closed this by deleting the head repository Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ssh signing] support custom signing program
2 participants