Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List and sort all projects, add captains #5653

Merged
merged 2 commits into from May 14, 2024

Conversation

blakeembrey
Copy link
Member

A few changes to the project list:

  1. Listing all active projects so we can easily see what exists
  2. Set myself as defacto on many of the lower level utils
  3. Assigned badgeboard to @wesleytodd based on recent commit (happy to undo?)
  4. Assigned jshttp/forwarded from @wesleytodd to myself since it seems similar to all the other jshttp modules I'm picking up (happy to undo this, wasn't sure if forwarded is special in some way)
  5. Assigned jshttp/http-assert to @wesleytodd and @jonchurch since it's similar to jshttp/http-errors
  6. Assigned pillarjs/router to myself based on recent discussions

None of this needs to be permanent and probably shouldn't be. I have probably too many lower level modules to work on, but I'll try to review one a day or something until v5 releases.

@blakeembrey blakeembrey requested a review from a team May 10, 2024 23:16
Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Contributing.md Outdated Show resolved Hide resolved
Copy link
Member

@sheplu sheplu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Copy link
Member

@wesleytodd wesleytodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to admit it is hard to read this as a diff, but I think it is good. Good to merge and we can fix anything in post since this is entirely a docs and loose thing.

@wesleytodd wesleytodd closed this May 14, 2024
@wesleytodd wesleytodd reopened this May 14, 2024
@wesleytodd wesleytodd merged commit a7d6d29 into expressjs:master May 14, 2024
3 checks passed
@blakeembrey blakeembrey deleted the be/project-captains branch May 14, 2024 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants