[video][android] Improve HLS compatibility #28997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behenate
force-pushed
the
@behenate/video/android-improve-hls-compat
branch
from
ae0c2f5
to
bb049df
Compare
expo-bot
added
bot: passed checks
|
The Pull Request introduced fingerprint changes against the base commit: 88d6feb Fingerprint diff[
{
"type": "dir",
"filePath": "../../packages/expo-video/android",
"reasons": [
"expoAutolinkingAndroid"
],
"hash": "7499c3dcc3d777233014a8ac6640189a3f90b17f"
}
]Generated by PR labeler 🤖 |
lukmccall
approved these changes
May 20, 2024
tsapeta
approved these changes
May 20, 2024
behenate
added a commit
that referenced
this pull request
May 28, 2024
# Why ExoPlayer has a special dependency that is required to stream HLS content, we should include it by default in `expo-video` to improve out-of-the-box media compatibility # How Added the `media3-exoplayer-hls` dependency to `build.gradle` # Test Plan Tested in BareExpo on android emulator. HLS live streams work now, where they weren't working before. (cherry picked from commit 0142227)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
ExoPlayer has a special dependency that is required to stream HLS content, we should include it by default in
expo-videoto improve out-of-the-box media compatibilityHow
Added the
media3-exoplayer-hlsdependency tobuild.gradleTest Plan
Tested in BareExpo on android emulator. HLS live streams work now, where they weren't working before.