Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1800 only one of the R groups is saved to CDX format #1956

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

#1800 only one of the R groups is saved to CDX format #1956

wants to merge 3 commits into from

Conversation

durlabh-epam
Copy link
Collaborator

@durlabh-epam durlabh-epam commented May 20, 2024 •
edited by even1024

Generic request

  • PR name follows the pattern #1234 – issue name
  • branch name does not contain '#'
  • base branch (master or release/xx) is correct
  • PR is linked with the issue
  • task status changed to "Code review"
  • code follows product standards
  • regression tests updated

@durlabh-epam durlabh-epam changed the title Changes to add altgroups on same level. #1800 only one of the R groups is saved to CDX format May 20, 2024
even1024
even1024 reviewed May 20, 2024
View reviewed changes
api/tests/integration/tests/formats/reactions/R3R4R5.ket Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the file is in wrong folder

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, will move it to molecules folder.

@even1024 even1024 linked an issue May 21, 2024 that may be closed by this pull request
Only one of the R groups is saved to CDX format. #1800
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@even1024 even1024 even1024 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Only one of the R groups is saved to CDX format.
2 participants
@durlabh-epam @even1024