Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pubsub cleanup #2969

Merged
merged 5 commits into from
May 20, 2024
Merged

Pubsub cleanup #2969

merged 5 commits into from
May 20, 2024

Conversation

diondokter
Copy link
Contributor

Exposes the new length functions on the pubs and subs and seals the pubsubbehavior trait (which users shouldn't (need to) touch).

I guess there's more to clean up or at least things I'd have made different now, but there's nothing that really needs more work.

For posterity:

  • I think it's weird that DynSubscriber<T> and Subscriber<T> both deref as Sub<Channel, T>.
  • Same for publisher
  • I'd make the shared functions into a trait and let each of the higher level types implement those traits
  • This would be a breaking change, but likely one that doesn't break anyone

Copy link
Member

@lulf lulf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lulf lulf added this pull request to the merge queue May 20, 2024
Merged via the queue into embassy-rs:main with commit 8e7361f May 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants