New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use //ui/shell_dialogs
on Linux
#42110
Merged
codebytere
merged 13 commits into
30-x-y
from
trop/30-x-y-bp-refactor-use-ui-shell_dialogs-on-linux-1715262710806
May 12, 2024
Merged
refactor: use //ui/shell_dialogs
on Linux
#42110
codebytere
merged 13 commits into
30-x-y
from
trop/30-x-y-bp-refactor-use-ui-shell_dialogs-on-linux-1715262710806
May 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
3 tasks
trop
bot
added
30-x-y
backport
This is a backport PR
semver/patch
backwards-compatible bug fixes
labels
May 9, 2024
ckerr
requested changes
May 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lint is failing & referring to patch files.
Maybe a patch update PR landed in 30-x-y
while this shell_dialogs PR has been in flight?
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
codebytere
force-pushed
the
trop/30-x-y-bp-refactor-use-ui-shell_dialogs-on-linux-1715262710806
branch
from
May 10, 2024 09:03
0e2f4fb
to
4a29aef
Compare
@ckerr yeah, just needed to delete the extra patch trop carried back! |
ckerr
approved these changes
May 10, 2024
codebytere
force-pushed
the
trop/30-x-y-bp-refactor-use-ui-shell_dialogs-on-linux-1715262710806
branch
from
May 10, 2024 18:27
eb54243
to
7033522
Compare
…gs-on-linux-1715262710806
codebytere
force-pushed
the
trop/30-x-y-bp-refactor-use-ui-shell_dialogs-on-linux-1715262710806
branch
from
May 10, 2024 18:31
7033522
to
05795be
Compare
codebytere
deleted the
trop/30-x-y-bp-refactor-use-ui-shell_dialogs-on-linux-1715262710806
branch
May 12, 2024 08:05
No Release Notes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #42045
See that PR for details.
Notes: none