Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use //ui/shell_dialogs on Linux #42110

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented May 9, 2024

Backport of #42045

See that PR for details.

Notes: none

trop bot and others added 11 commits May 9, 2024 13:51
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
@trop trop bot requested a review from a team as a code owner May 9, 2024 13:52
@trop trop bot requested review from codebytere and a team May 9, 2024 13:53
@trop trop bot mentioned this pull request May 9, 2024
3 tasks
@trop trop bot added 30-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels May 9, 2024
Copy link
Member

@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lint is failing & referring to patch files.

Maybe a patch update PR landed in 30-x-y while this shell_dialogs PR has been in flight?

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
@codebytere codebytere force-pushed the trop/30-x-y-bp-refactor-use-ui-shell_dialogs-on-linux-1715262710806 branch from 0e2f4fb to 4a29aef Compare May 10, 2024 09:03
@codebytere
Copy link
Member

@ckerr yeah, just needed to delete the extra patch trop carried back!

@codebytere codebytere requested a review from ckerr May 10, 2024 09:04
@codebytere codebytere force-pushed the trop/30-x-y-bp-refactor-use-ui-shell_dialogs-on-linux-1715262710806 branch from eb54243 to 7033522 Compare May 10, 2024 18:27
@codebytere codebytere force-pushed the trop/30-x-y-bp-refactor-use-ui-shell_dialogs-on-linux-1715262710806 branch from 7033522 to 05795be Compare May 10, 2024 18:31
@codebytere codebytere merged commit 4d988dd into 30-x-y May 12, 2024
13 checks passed
@codebytere codebytere deleted the trop/30-x-y-bp-refactor-use-ui-shell_dialogs-on-linux-1715262710806 branch May 12, 2024 08:05
Copy link

release-clerk bot commented May 12, 2024

No Release Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
30-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants