feat: remove File.path #42053
Merged
feat: remove File.path #42053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nornagon
added
semver/major
electron-cation
bot
added
new-pr 🌱
erickzhao
approved these changes
May 6, 2024
![electron-docs-reviewer[bot]](https://avatars.githubusercontent.com/in/243740?s=60&v=4){kind=small}
|
Are we purposely not giving this a full deprecation cycle and going straight to yanking it? |
It was quasi-deprecated in #38776, though it didn't get a breaking-changes.md callout. |
nornagon
removed
the
target/31-x-y
|
Moved the deletion to 32.x |
🪦 Deprecation Checklist🗑️ Previous deprecations being removed in this PR
@electron/wg-releases: Please confirm these deprecation changes conform to our deprecation policies listed in |
electron-cation
bot
added
deprecation-review/complete ✅
and removed
deprecation-review/requested 📝
labels
ckerr
approved these changes
May 7, 2024
There was a problem hiding this comment.
Thanks for this @nornagon and also thanks @MarshallOfSound for #38776
jkleinsc
reviewed
May 13, 2024
electron-cation
bot
added
api-review/approved ✅
and removed
new-pr 🌱
|
Release Notes Persisted
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
It's time.
Checklist
npm testpassesRelease Notes
Notes: Removed nonstandard
File.pathextension from the WebFileAPI.