-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat notarization: use notarytool for code-signing #3492
base: main
Are you sure you want to change the base?
feat notarization: use notarytool for code-signing #3492
Conversation
Was looking forward to this! |
@amilajack just learnt that electron-builder already notarizes the app. I have added a fix to this PR to stop this and only use the I am not the right person to implement this solution so feel free to take this forward as you like, but would love to see Referring to how electron builder handles notarization might be useful here |
How are |
appBundleId: build.appId, | ||
appPath: `${appOutDir}/${appName}.app`, | ||
appleId: process.env.APPLE_ID, | ||
appleIdPassword: process.env.APPLE_ID_PASS, | ||
teamId: process.env.APPLE_TEAM_ID |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would also check for APPLE_TEAM_ID
and log and error in the if-statement above.
Using the script and setting |
in
the environment variables this above config will automatically get also note that the environment variable |
The default alt-tool has been deprecated for more than a year and will soon become unsupported
Here's the issue tracking the change in electron notarize
And based on the changes being made to support this it will be a breaking change, that will later use
notarytool
as the default (which is also recommended by apple documentation)This PR adds changes to now use the
notarytool
for code-signing. But this also requires the environment to have an extraAPPLE_TEAM_ID
variable to be set. This is the team ID you want to notarize under.