Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Connectors] Fix customized connector marked as beta #183842

Merged
merged 2 commits into from
May 21, 2024

Conversation

jedrazb
Copy link
Member

@jedrazb jedrazb commented May 20, 2024

Summary

Customized connector should be considered as GA, not BETA.

Screenshots from config step

No beta label:
Screenshot 2024-05-20 at 16 52 03

No beta callout:
Screenshot 2024-05-20 at 16 52 34

No beta in the bottom right column:
Screenshot 2024-05-20 at 16 53 04

Describe the bug with wrong beta labels before:

image

image image

@jedrazb jedrazb added release_note:skip Skip the PR/issue when compiling release notes v8.14.0 v8.15.0 labels May 20, 2024
@@ -88,9 +88,9 @@ export const ConnectorConfiguration: React.FC = () => {
({ serviceType }) => serviceType === connector.service_type
)?.docsUrl;

const isBeta =
!connector.service_type ||
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

customized_connector by default has null service type, so it was a trick to mark this as beta, we can get rid of it now

@jedrazb jedrazb marked this pull request as ready for review May 20, 2024 14:56
@jedrazb jedrazb requested a review from a team as a code owner May 20, 2024 14:56
@jedrazb jedrazb merged commit 9168047 into elastic:main May 21, 2024
5 checks passed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 21, 2024
Customized connector should be considered as GA, not BETA.

(cherry picked from commit 9168047)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.14

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label May 23, 2024
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

8 similar comments
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport missing Added to PRs automatically when the are determined to be missing a backport. release_note:skip Skip the PR/issue when compiling release notes v8.14.0 v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants