Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Embeddables] Fix missing panel references when Duplicate, Copy to Dashboard, or Save as new dashboard #183778

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

nickpeihl
Copy link
Member

@nickpeihl nickpeihl commented May 17, 2024

Fixes #183551

Summary

Fixes missing references on React embeddables when Duplicate, Copy to Dashboard, or Save as new dashboard.

To test this:

  1. Start Kibana with yarn start --run-examples.
  2. Install at least two sample datasets.
  3. Create a new dashboard and add a Field list panel.
  4. Change the data view in the Field list panel to something other than the default data view.
  5. Duplicate the panel and ensure the data view does not revert to the default.
  6. Copy the panel to a new or existing dashboard and ensure the data view does not revert.
  7. Save the dashboard to a new dashboard and ensure the data view does not revert.

@nickpeihl nickpeihl changed the title [Embeddables] Fix duplicate panel react embeddable [Embeddables] Fix missing panel references when Duplicate, Copy to Dashboard, or Save as new dashboard May 24, 2024
@nickpeihl
Copy link
Member Author

/ci

@nickpeihl
Copy link
Member Author

/ci

@nickpeihl
Copy link
Member Author

/ci

@nickpeihl
Copy link
Member Author

/ci

@nickpeihl nickpeihl added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas release_note:skip Skip the PR/issue when compiling release notes project:embeddableRebuild v8.15.0 labels May 24, 2024
@nickpeihl nickpeihl marked this pull request as ready for review May 24, 2024 23:41
@nickpeihl nickpeihl requested a review from a team as a code owner May 24, 2024 23:41
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@nickpeihl nickpeihl marked this pull request as draft May 24, 2024 23:45
@nickpeihl nickpeihl marked this pull request as ready for review May 29, 2024 16:31
@nickpeihl
Copy link
Member Author

/ci

@botelastic botelastic bot added the Feature:Embedding Embedding content via iFrame label May 31, 2024
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #44 / console app console vector tiles response validation "before all" hook for "should validate response"

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
dashboard 113 116 +3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dashboard 495.5KB 495.7KB +276.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
dashboard 43.4KB 43.5KB +131.0B
Unknown metric groups

API count

id before after diff
dashboard 116 120 +4
embeddable 554 555 +1
total +5

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Embedding Embedding content via iFrame project:embeddableRebuild release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Embeddables] Duplicate, Copy to dashboard, and Save as new dashboard actions do not include references
4 participants