Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[canvas] fix parent API should implement unified search interface with react embeddables #183772

Merged
merged 6 commits into from
May 22, 2024
Merged

[canvas] fix parent API should implement unified search interface with react embeddables #183772

merged 6 commits into from
May 22, 2024

Conversation

nreese
Copy link
Contributor

@nreese nreese commented May 17, 2024

Closes #183766

test instructions

  1. start kibana with yarn start --run-examples
  2. install sample web logs data set
  3. create new canvas work pad
  4. Click "Add element" -> "Filter" -> "Dropdown select"
  5. Select "data" tab and configure filter to pull from logs sample data and machine.os.keyword field.
  6. Select "display" tab and "Value column" and "Filter column" to machine.os.keyword.
  7. Click "Add element" -> "Filter" -> "Time filter"
  8. Click "Select type" -> "Search example"
  9. Click panel context menu -> "Settings" and turn off custom time range
  10. Click "Expression editor" button in lower right corner to open the expression editor for the map and prefix the expression with kibana | selectFilter | embeddable
    Screenshot 2024-05-17 at 11 50 42 AM
  11. Interact with drop down filter and time range filter. Verify Search react embeddable updates as expected

@nreese
Copy link
Contributor Author

nreese commented May 17, 2024

/ci

1 similar comment
@nreese
Copy link
Contributor Author

nreese commented May 17, 2024

/ci

@nreese nreese requested a review from cqliu1 May 17, 2024 18:56
@nreese nreese marked this pull request as ready for review May 17, 2024 19:03
@nreese nreese requested a review from a team as a code owner May 17, 2024 19:03
@nreese nreese added release_note:fix Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Feature:Canvas v8.15.0 labels May 17, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@nreese nreese added loe:medium Medium Level of Effort impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. labels May 17, 2024
@nreese nreese mentioned this pull request May 17, 2024
Draft
1 task
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #25 / Actions and Triggers app Rules list rules list should disable single alert

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
canvas 1234 1268 +34

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/presentation-publishing 163 167 +4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
canvas 1.1MB 1.1MB +1.1KB
Unknown metric groups

API count

id before after diff
@kbn/presentation-publishing 197 202 +5

ESLint disabled line counts

id before after diff
@kbn/presentation-publishing 2 3 +1

Total ESLint disabled count

id before after diff
@kbn/presentation-publishing 2 3 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

ThomThomson
ThomThomson approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@ThomThomson ThomThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I looked through the code and went through the local testing instructions. Everything looks good to me!

Too bad about the auto-applying panel time range in Canvas, but that's completely out of scope for this PR.

packages/presentation/presentation_publishing/interfaces/fetch/publishes_unified_search.ts
/**
* React hook that converts search props into search observable API
*/
export function useSearchApi({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition here. I see this getting a lot of use.

@nreese nreese merged commit f8c582d into elastic:main May 22, 2024
18 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomThomson ThomThomson ThomThomson approved these changes

@cqliu1 cqliu1 Awaiting requested review from cqliu1

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Canvas impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:medium Medium Level of Effort release_note:fix Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[canvas] parent API should implement unified search interface with react embeddables
5 participants
@nreese @elasticmachine @kibana-ci @ThomThomson @kibanamachine