Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add release notes for v8.14.0 release #108827

Merged
merged 3 commits into from
May 20, 2024
Merged

Add release notes for v8.14.0 release #108827

merged 3 commits into from
May 20, 2024
+385 −8

Conversation

elasticsearchmachine
Copy link
Collaborator

This PR was auto-generated. Please review, edit, and move out of Draft.

@elasticsearchmachine elasticsearchmachine added >docs General docs changes v8.14.0 labels May 20, 2024
@github-actions GitHub Actions
Copy link

Documentation preview:

@brianseeders
Copy link
Contributor

@elasticmachine merge upstream

@brianseeders brianseeders marked this pull request as ready for review May 20, 2024 19:26
@elasticsearchmachine elasticsearchmachine added the Team:Docs Meta label for docs team label May 20, 2024
@elasticsearchmachine
Copy link
Collaborator Author

Pinging @elastic/es-docs (Team:Docs)

@brianseeders
Copy link
Contributor

Sorry about the delay, there were some issues with our automation.

chriscressman
chriscressman reviewed May 20, 2024
View reviewed changes
Copy link
Member

@chriscressman chriscressman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brianseeders I'm not sure how this file is created, but I see some content in there that is written in markdown rather than asciidoc. Therefore, the "what's new" page isn't rendering correctly.

https://github.com/elastic/elasticsearch/blob/8.14/docs/reference/release-notes/highlights.asciidoc#query-phase-knn-now-supports-query_vector_builder

@brianseeders
Copy link
Contributor

@chriscressman those pages never render correctly in Github, right? You need to look at the docs preview link? https://elasticsearch_bk_108827.docs-preview.app.elstc.co/guide/en/elasticsearch/reference/8.14/release-highlights.html

@chriscressman
Copy link
Member

@brianseeders Yeah, definitely. Here is a screenshot of what I'm talking about:

Screenshot 2024-05-20 at 17-08-00 What’s new in 8 14 Elasticsearch Guide 8 14 Elastic

@brianseeders
Copy link
Contributor

@chriscressman Ah yes. It looks like the author of the PR originally wrote the description in markdown on accident. I just changed it.

chriscressman
chriscressman approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@chriscressman chriscressman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@brianseeders brianseeders merged commit d93a199 into 8.14 May 20, 2024
6 checks passed
@brianseeders brianseeders deleted the release-notes-8-14-0 branch May 20, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriscressman chriscressman chriscressman approved these changes

Assignees
No one assigned
Labels
>docs General docs changes Team:Docs Meta label for docs team v8.14.0 v8.14.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@elasticsearchmachine @brianseeders @chriscressman @elasticmachine