Read scan count once instead of once per vector to avoid issue where scan counts between vectors could become mis-aligned in concurrent scenarios #12135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…scan counts between vectors could become mis-aligned in concurrent scenarios
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
May 20, 2024
Merge pull request duckdb/duckdb#12135 from Mytherin/concurrentvectorscan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this could result in an
InternalExceptionbeing triggered in scenarios where we are appending data to the same table while we are also reading it - this would happen when theStandardColumnDatathinks we are scanning an entire vector (and hence can emit aConstantVector) but theValidityColumnDatathinks we are not.