FreeDV: Disable LPCNet on 32-bit ARM. #230
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR disables LPCNet for 32-bit builds to allow FreeDV to build on 32-bit Bookworm. 64-bit builds should still include it, though (if I'm understanding Ansible correctly, anyway; I'm having difficulty testing this change my own Pi due to it complaining about not being able to find the latest version of CMake on GitHub).
For context: FreeDV traditionally required LPCNet to build/execute even if the machine was too slow to be able to use the FreeDV 2020 modes. As 2020/2020B modes may be deprecated soon, it was decided to perform only minimal maintenance on the FreeDV version of the LPCNet library (meaning that changes to allow it to build on the 32-bit ARM version of Bookworm are probably not coming any time soon) and uncouple the main FreeDV application from LPCNet.