Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update D-Rat install #193

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

wsciaroni
Copy link
Contributor

Where I was running the install, I was not able to install D-Rat on Ubuntu 22.04.

I updated the build dependencies to be able to build D-Rat.

I updated the repo path for D-Rat to https://github.com/ham-radio-software/D-Rats.git

@dslotter
Copy link
Owner

dslotter commented Sep 9, 2022

Where I was running the install, I was not able to install D-Rat on Ubuntu 22.04.

I updated the build dependencies to be able to build D-Rat.

I updated the repo path for D-Rat to https://github.com/ham-radio-software/D-Rats.git

Ok, changing out the repo for D-Rats is a really big change... I've been watching the new author's work and am very impressed, but I have not yet reviewed how ready it is for "prime time". What do you know about this new version, @wsciaroni ? Please share your findings and/or recommendations.

@@ -62,49 +62,9 @@
name: "{{ item }}"
state: present
with_items:
- python
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I so want to get rid of all this dependency "soup"...

@@ -113,7 +73,7 @@

- name: Download D-Rats sources
git:
repo: https://github.com/maurizioandreotti/D-Rats.git
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my earlier comment about changing out the repo.

Copy link
Owner

@dslotter dslotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's talk about my concerns about switching out the repo... If you have information that this new version is working and is at least as good as Maurizio's if not better (by supporting Python 3), then I would be eager to switch...

@wsciaroni
Copy link
Contributor Author

Let's talk about my concerns about switching out the repo... If you have information that this new version is working and is at least as good as Maurizio's if not better (by supporting Python 3), then I would be eager to switch...

Honestly, I did this in such a rush that I didn't realize it wasn't just a mirror of the same project.....

Looking at the repository, it seems that they are pretty active. According to the README of the new project, this is still an experimental fork. Maybe Maurizio would like to try out a build of HamPi with this installed so that they could verify full functionality?

Maybe we can get your thoughts @maurizioandreotti

@dslotter
Copy link
Owner

dslotter commented Sep 9, 2022

Let's talk about my concerns about switching out the repo... If you have information that this new version is working and is at least as good as Maurizio's if not better (by supporting Python 3), then I would be eager to switch...

Honestly, I did this in such a rush that I didn't realize it wasn't just a mirror of the same project.....

Looking at the repository, it seems that they are pretty active. According to the README of the new project, this is still an experimental fork. Maybe Maurizio would like to try out a build of HamPi with this installed so that they could verify full functionality?

Maybe we can get your thoughts @maurizioandreotti

We also should request input from @wb8tyw

@wsciaroni
Copy link
Contributor Author

Actually, @dslotter It looks like they officially migrated out of the old repository. Take a look at the old repo. They are sending users to the new repo path that I used.

@dslotter
Copy link
Owner

dslotter commented Sep 9, 2022

Actually, @dslotter It looks like they officially migrated out of the old repository. Take a look at the old repo. They are sending users to the new repo path that I used.

I see that too now that you pointed me to it... So we could "continue" to point to the old project, but we will never get any new updates as it's now deprecated. So we need to look at the new version closely... Is this something you can do? Meaning we need this to run under HamPi 32 bit no matter what, and preferably under HamPi 64 bit and HamPC.

@wsciaroni
Copy link
Contributor Author

Actually, @dslotter It looks like they officially migrated out of the old repository. Take a look at the old repo. They are sending users to the new repo path that I used.

I see that too now that you pointed me to it... So we could "continue" to point to the old project, but we will never get any new updates as it's now deprecated. So we need to look at the new version closely... Is this something you can do? Meaning we need this to run under HamPi 32 bit no matter what, and preferably under HamPi 64 bit and HamPC.

I have yet to build a stable version of HamPi or HamPC from sources... I've made partial builds of HamPC. (I don't actually have a Pi)

@wb8tyw
Copy link

wb8tyw commented Sep 9, 2022

I am totally ignorant of the HamPi project.

This is what happened:

  • Maurizio and I planned a migration from his personal github project to the ham-radio-software organization github project. The use of a github project allows better control of collaborators, and a more permanent URI for use. It also allows with the proper planning continuity if a single person is unable to continue with the project.

  • After the move, I was to create a 0.3 branch for the python2 code, and merge in the python3 code.

  • Due to several personal issues, I was unable to do that task for about a week, hence there was no Python 3 / Gtk 3 code there until recently.

  • The old Python 2 d-rats packaging methods have been deprecated. I have made one pass at converting to a new supported method with some limited success.

I am now looking at improving the packaging of D-Rats. The first step is getting the lzhuf program into its own native package for all platforms.

Side note: If hzhuf was added to D-Rats before the LZW patents it depended on expired in 2003/2004 then who ever added it was (and depending on country of residence may still be) at risk of getting sued out of everything they owned. No open source repository or Linux distribution would knowingly accept a package containing a LZH compressor, only de-compressors.

I have a lot to learn about getting the packaging right and of the use of GitHub actions for doing the packaging, especially for Microsoft Windows. I have some experience with creating RPMs and DEB files in a chroot inside of a dockerfile.

So if there is any way we can work together, I am interested.

Github actions can be used to run code in arm64 and x86 docker containers and they have runners for MAC OS and Microsoft Windows Server. So that should be everything needed to create binary packages and even run tests on PRs.

@wb8tyw
Copy link

wb8tyw commented Sep 9, 2022

D-Rats using the new build procedure in the ReadMe when run on a cloned repository will create a Pip installable tarball with a requirements.txt file.

I have not had time to setup docker chroot builds of debian files.

The cloned repository is need as D-Rats is now getting the version based on the latest tag in the repository.

@dslotter
Copy link
Owner

dslotter commented Sep 9, 2022

@johng42 Is the Python 3 version of D-Rats reasonably stable to distribute en masse? Meaning, HamPi is a free, open-source ham radio software image consisting of over 100 ham radio applications (D-Rats included) for the Raspberry Pi SBC. And HamPC is the same thing, but for the x86_64 PC laptop or desktop. I know there are minor bugs -- but are there any "deal breakers" for running the Python 3 version of D-Rats? (There are thousands, if not tens of thousands of users of HamPi and HamPC.) Please advise, and thank you.

@johng42
Copy link
Contributor

johng42 commented Sep 9, 2022

I have no insight here. I looked at this project a while back but never did any work on it. Sorry!

@wb8tyw
Copy link

wb8tyw commented Sep 10, 2022

The D-Rats release_0.3 branch is the Python 2 version of D-Rats which used to be the Master branch.

The D-Rats 0.3.6b6 tag is the most current version of Python 2 D-Rats. That specific version has not been tested, but the only change from the former Master branch is that it has the REQUIRED COPYRIGHT ATTRIBUTIONS for the data sources used. Distributing D-Rats with out those notices included is in violation of the terms of use for those data services.

No further work is planned for the release_0.3 branch by my self or Maurizio.
I am no longer setup to test the release_0.3 branch.

Bugs found in the converting the master branch to Python 3 were not back ported to the release_0.3 branch.

@wb8tyw
Copy link

wb8tyw commented Sep 10, 2022

The D-Rats Master branch has been only tested by a few people, but appears to be functionally on par with the release_0.3 branch.

  • It add Winlink connections to x86_64 and later Mac-OSX. PowerPC is still broken.
  • It adds all "Radio" types for use with Ratflectors.
  • It fixes file/form transfers from Big-Endian platforms like PowerPC.
  • Map marker positioning is now accurate.

The single windows executable for D-Rats is not implemented at this time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants