xWebVirtualDirectory: Fails to create directory under application

[omiossec]

As a proposed solution to the #331 issue I propose to change the way the resource checks Virtual Directory.

This Pull Request (PR) fixes the following issues

• Fixes xWebVirtualDirectory Fails to create a virtual directory if it already exists #331

Task list

• [ x] Added an entry to the change log under the Unreleased section of the CHANGELOG.md.
  Entry should say what was changed and how that affects users (if applicable), and
  reference the issue being resolved (if applicable).
• Resource documentation added/updated in README.md.
• Resource parameter descriptions added/updated in README.md, schema.mof
  and comment-based help.
• Comment-based help added/updated.
• Localization strings added/updated in all localization files as appropriate.
• Examples appropriately added/updated.
• Unit tests added/updated. See DSC Resource Testing Guidelines.
• Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
• New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

---

This change is 

[johlju]

Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed, 6 unresolved discussions (waiting on @omiossec)

a discussion (no related file):
Can we add integration tests that tests the scenario(s) the change resolves?

---

a discussion (no related file):
Please add unit tests for this change.

---

a discussion (no related file):
We could leave as-it, but instead of duplicating code in Set- and Test-function, we should refactor the code to call the Get-function. We could improve this in another PR. You choice.

---

---

CHANGELOG.md, line 6 at r1 (raw file):

Update on how Virtual directory are tested to correct the issue

Can we please add a bit more descriptive text what this change fixes and how it affects the (users) existing configurations?

---

DSCResources/MSFT_xWebVirtualDirectory/MSFT_xWebVirtualDirectory.psm1, line 52 at r1 (raw file):

    Assert-Module

    if ($null -eq $WebApplication -OR $WebApplication.Length -eq 0)

Good as-is but we could evaluate this using IsNullOrEmpty()
https://github.com/PowerShell/xWebAdministration/blob/c33e56b254b1b50111f13175b3fef8075384ae6e/Tests/Unit/MSFT_xWebAppPoolDefaults.Tests.ps1#L53

---

DSCResources/MSFT_xWebVirtualDirectory/MSFT_xWebVirtualDirectory.psm1, line 56 at r1 (raw file):

else {

We should have open-brace on a separate row.

---

DSCResources/MSFT_xWebVirtualDirectory/MSFT_xWebVirtualDirectory.psm1, line 121 at r1 (raw file):

    if ($Ensure -eq 'Present')
    {
        if ($null -eq $WebApplication -OR $WebApplication.Length -eq 0)

See previous comments in Get-function.

---

DSCResources/MSFT_xWebVirtualDirectory/MSFT_xWebVirtualDirectory.psm1, line 203 at r1 (raw file):

    Assert-Module

    if ($null -eq $WebApplication -OR $WebApplication.Length -eq 0)

See previous comments in Get-function.

[johlju]

@regedit32 Do you have time to look over this too? You have a better knowledge around these cmdlets than me. 😄

[regedit32]

@johlju solution looks good, but I will take another look after tests have been added.

[johlju]

We have renamed the resource, removing 'x', so please rebase this PR.