Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource: xWebSiteAlive (fixes #84) #309

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

rosberglinhares
Copy link
Contributor

@rosberglinhares rosberglinhares commented Jun 12, 2017

The resource xWebSiteAlive is ready for review.

This resource came from #84.


This change is Reviewable

…odule.

Avoiding files with unicode file encoding.

Avoiding files with tab characters.
It is not necessary to create a directory for the test website. A new binding on the same physical path is sufficient.

Avoiding the 'There is no call to Write-Verbose' messages.
@johlju
Copy link
Member

johlju commented Apr 23, 2018

@rosberglinhares are you able to working on this PR? If so I can help you review it and get it merged. There are merge conflicts, can you resolve them? 🙂

@johlju johlju added the waiting for author response The pull request is waiting for the author to respond to comments in the pull request. label Apr 23, 2018
@johlju
Copy link
Member

johlju commented May 23, 2018

Labeling this PR as abandoned since it has gone 14 days or more since the last update. An abandoned PR can be continued by another contributor. The abandoned label will be removed if work on the PR is taken up again.

@johlju johlju added abandoned The pull request has been abandoned. and removed waiting for author response The pull request is waiting for the author to respond to comments in the pull request. labels May 23, 2018
@SteveL-MSFT SteveL-MSFT added this to Abandoned in powershell/dscresources May 14, 2019
@SteveL-MSFT SteveL-MSFT removed this from Abandoned in powershell/dscresources Nov 27, 2019
@johlju johlju changed the base branch from dev to master December 30, 2019 12:19
@johlju johlju changed the base branch from master to main January 7, 2021 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
abandoned The pull request has been abandoned.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants