OCSP Stapling added #798
Open
OCSP Stapling added #798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@adityapatadia Thank you for the contribution 👍 I understand how enabling OSCP stapling can be useful but I would like to understand further why you are proposing this as a default for all Discourse instances that uses |
tgxworld
reviewed
May 9, 2024
| @@ -125,6 +125,10 @@ hooks: | |||
| to: | | |||
| ssl_certificate_key /shared/ssl/$$ENV_DISCOURSE_HOSTNAME.key; | |||
| ssl_certificate_key /shared/ssl/$$ENV_DISCOURSE_HOSTNAME_ecc.key; | |||
| ssl_stapling on; | |||
| ssl_stapling_verify on; | |||
There was a problem hiding this comment.
According to Nginx's doc,
For verification to work, the certificate of the server certificate issuer, the root certificate, and all intermediate certificates should be configured as trusted using the ssl_trusted_certificate directive.
Are we missing the ssl_trusted_certificate directive for this to work?
|
That’s because all users who use docker will benefit from increased speed.
We expect most users will be using lets encrypt and it’s best to have OCSP.
If there is not a good reason to disable it, it should be enabled for all.
Regards,
Aditya Patadia
…On Thu, 9 May 2024 at 1:05 PM, Alan Guo Xiang Tan ***@***.***> wrote:
@adityapatadia <https://github.com/adityapatadia> Thank you for the
contribution 👍 I understand how enabling OSCP stapling can be useful but I
would like to understand further why you are proposing this as a default
for all Discourse instances that uses web.letsencrypt.ssl.template.yml.
—
Reply to this email directly, view it on GitHub
<#798 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIJJGL6N32275FYD6JYV3LZBMRNLAVCNFSM6AAAAABHISNNC2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBSGEZDAMZWGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.