FIX: Broken config and variable handling in setup script #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djlambert
force-pushed
the
setup-script-fix
branch
from
d73b5d5
to
6852fc8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The value of
smtp_passwordis never cleared if the value ofDISCOURSE_SMTP_PASSWORDequals the stringpa$$word. Presumably that what's indented, and not using the process ID 😉The variable
discourse_smtp_DOMAINis never used. The domain is forced to be that ofDISCOURSE_NOTIFICATION_EMAIL. Now ifDISCOURSE_SMTP_DOMAINis defined it's used instead.