Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: show selected topic with above-topic-list-item #26928

Merged
merged 1 commit into from May 13, 2024

Conversation

Gravitonic
Copy link
Contributor

In a topic item list, the row currently selected by the j/k keyboard shortcuts is indicated by a style applied to the td:first-child of selected rows, but the "above-topic-list-item" plugin outlet allows for inserting elements as the first child of those rows. If the inserted element is not a <tr> element, then there's no element matching the CSS selector and thus no way to tell what row is currently selected to navigate from.

For example, the Clickable Topic plugin inserts a hidden <div> in the "above-topic-list-item" plugin outlet which means there's no visual indication of what item is selected.

Copy link
Contributor

@pmusaraj pmusaraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Gravitonic, this makes sense!

@pmusaraj pmusaraj merged commit 84d0ac3 into discourse:main May 13, 2024
9 of 16 checks passed
@Gravitonic Gravitonic deleted the above-topic-list-item-selected branch May 13, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants