UX: show disclaimer on account creation unconditionally #26807
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment this won't appear if
tos_url
andprivacy_policy_url
are undefined... I don't believe these settings are serialized in the case oflogin_required
, so the disclaimer will never appear:https://meta.discourse.org/t/terms-of-service-privacy-policy-agreement-notice-missing-when-forum-log-in-is-forced/305744
When these settings are set,
/tos
and/privacy
redirect to the setting URL... so maybe we don't need the check at all here?The one case this isn't cover is when the default TOS and Privacy Policy aren't generated, which can happen if a company name isn't added to the site setup wizard. Though I wonder if the broken state is more desirable to bring an admin's attention to this issue 馃
Very possible this is more complicated... so feel free to close if this is an oversimplification.