Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX: show disclaimer on account creation unconditionally #26807

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

awesomerobot
Copy link
Member

@awesomerobot awesomerobot commented Apr 29, 2024

At the moment this won't appear if tos_url and privacy_policy_url are undefined... I don't believe these settings are serialized in the case of login_required, so the disclaimer will never appear:

https://meta.discourse.org/t/terms-of-service-privacy-policy-agreement-notice-missing-when-forum-log-in-is-forced/305744

When these settings are set, /tos and /privacy redirect to the setting URL... so maybe we don't need the check at all here?

The one case this isn't cover is when the default TOS and Privacy Policy aren't generated, which can happen if a company name isn't added to the site setup wizard. Though I wonder if the broken state is more desirable to bring an admin's attention to this issue 馃

Very possible this is more complicated... so feel free to close if this is an oversimplification.

@discoursebot
Copy link

This pull request has been mentioned on Discourse Meta. There might be relevant details there:

https://meta.discourse.org/t/terms-of-service-privacy-policy-agreement-notice-missing-when-forum-log-in-is-forced/305744/4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants