Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV: Skip DetectTranslation jobs for small action posts #143

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

markvanlan
Copy link

This is an extension of this commit - 1c84ffe

We had a problem on a site where a bunch of jobs were enqueued to detect the language of the same small post. Not sure what triggered this, but it caused an endless stream of revised message bus messages to the client, causing network requests to flood the server and rate limit clients.

This does a super-safe job of

  1. not enqueueing the process job for small/empty posts
  2. returning early in the job if a post somehow made it through

@markvanlan markvanlan changed the title DEV: Skip processing small actions DEV: Skip DetectTranslation jobs for small action posts May 16, 2024
@markvanlan
Copy link
Author

Eh I thought this was still an issue. It shouldnt' be. But gosh enqueueing a job from a serializer that triggers a refresh, making the serializer run again potentially enqueueing the job again... spooky stuff here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant