-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reload button when the app errors out #22462
Conversation
🦋 Changeset detectedLatest commit: 4150b7c The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Co-authored-by: Hannes Küttner <4376726+hanneskuettner@users.noreply.github.com>
Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@paescuj The unexpected_error_copy
is a generic message which is here:
directus/app/src/modules/content/routes/collection.vue
Lines 504 to 506 in 6c28725
<template #error="{ error, reset }"> | |
<v-info type="danger" :title="t('unexpected_error')" icon="error" center> | |
{{ t('unexpected_error_copy') }} |
Should we add a new string unexpected_error_reload
if we need to change it?
On the other hand, I think the "Try Again" button might be misleading as we are doing a reload and not retrying.
Right. Hmm, I think it would already be sufficient if we drop the "later", so "Please try again". It feels wrong to tell the user to try later, while presenting a reload button at the same time. |
Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
Scope
What's changed:
Potential Risks / Drawbacks
Review Notes / Questions
Related to #22360 where the app errors out but without any action for users to proceed with