Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #2349

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update README.md #2349

wants to merge 3 commits into from

Conversation

rezabojnordi
Copy link

adding golang

@derailed
Copy link
Owner

@rezabojnordi Thanks for this update Reza!
No sure this should belong in the k9s docs but perhaps best to just link to the standard GO install documentation??

@derailed derailed added enhancement New feature or request question Further information is requested labels Dec 18, 2023
@rezabojnordi
Copy link
Author

you're welcome
but I think the client just needs to use this repository and doesn't need to search for how to install Golang

derailed
derailed reviewed Dec 19, 2023
View reviewed changes
Copy link
Owner

@derailed derailed left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rezabojnordi Thank you for these updates. Not super keen of including the training wheels here ie if users don't know how to set shell env vars then building/installing k9s from source might not be the best option??

README.md
```bash
wget https://golang.org/dl/goX.Y.Z.linux-amd64.tar.gz

sudo tar -xvf go1.21.0.linux-amd64.tar.gz -C /usr/local
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might as well continue with the X.Y.Z theme...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yah I agree with you and I removed it

README.md Outdated Show resolved Hide resolved
@derailed derailed added the needs-tlc Pr needs additional updates label Dec 27, 2023
derailed
derailed requested changes May 18, 2024
View reviewed changes
Copy link
Owner

@derailed derailed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rezabojnordi Thank you for the updates! Looks like we have some conflicts ;(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derailed derailed derailed requested changes

Assignees
No one assigned
Labels
enhancement New feature or request needs-tlc Pr needs additional updates question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rezabojnordi @derailed