refactor(lsp): reuse CliGraphResolverOptions::sloppy_imports_resolver #23764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nayeemrmn
commented
May 10, 2024
dsherret
reviewed
May 10, 2024
cli/resolver.rs
Outdated
| @@ -1065,7 +1053,7 @@ impl SloppyImportsResolver { | |||
| } | |||
|
|
|||
| let probe_paths: Vec<(PathBuf, SloppyImportsResolutionReason)> = | |||
| match (stat_sync)(&path) { | |||
| match self.stat_cache.stat_sync(&path) { | |||
There was a problem hiding this comment.
One thing we're probably going to have to do with this change is not use a stat cache because it will get out of date.
Another point to note (that I mentioned on the last PR, but worth re-iterating to keep in mind) is that sloppy import resolution may change when a file is added or deleted. Probably in the future (I wouldn't suggest as part of this PR), we'll need to invalidate resolved resolution more when using sloppy imports.
…fallback resolution
…allback resolution
dsherret
reviewed
May 13, 2024
dsherret
reviewed
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So we don't need to have separate hooks in
LspGraphResolver::resolve().Unrelated: Remove redundant 1-layer dep recursion in
op_script_names(). Cleanup other resolver interfaces.