-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: lazy OSX frameworks with lzld
#23716
base: main
Are you sure you want to change the base?
Conversation
littledivy
commented
May 6, 2024
•
edited
edited
lzld
lzld
[WIP]
lzld
[WIP]lzld
tools/lzld/liblzld_arm64.a
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be built during the rust build?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, but it'll be pretty rarely updated. We should do it like N-API symbols list, which are rebuilt manually when there is a change.
// For remote debugging only. | ||
// { | ||
// name: "Setup tmate session", | ||
// if: [ | ||
// "(matrix.job == 'test' || matrix.job == 'bench') &&", | ||
// "matrix.profile == 'debug' && (matrix.use_sysroot ||", | ||
// "github.repository == 'denoland/deno')", | ||
// ].join("\n"), | ||
// uses: "mxschmitt/action-tmate@v3", | ||
// }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep this commented out in the codebase? Quite useful for debugging CI remotely :)
if (events.length > 2) break; | ||
if (events.length >= 2) break; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Funny that this function name is getTwoEvents
and waits for 3 instead. Spotted this bug by switching to the kqueue backend, nice.
|
||
// -- QuartzCore.framework | ||
|
||
extern void *kCAGravityTopLeft = 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix this warning
~/src/deno/tools/lzld# make
cc -c lzld.m -o lzld.o
lzld.m:17:14: warning: 'extern' variable has an initializer [-Wextern-initializer]
extern void *kCAGravityTopLeft = 0;
^
1 warning generated.
ar rcs liblzld_arm64.a lzld.o