Backport 'Fix admin language selector' to v0.28

[andreslucena]

🎩 What? Why?

Backport #12709 to v0.28

♥️ Thank you!

[alecslupu]

👍

[andreslucena]

@alecslupu as I mentioned in our last meeting, I'm not sure what it may be happening here.

This is the typical case of "It Works In My Machine" - like if I run the specs in this branch with a new test_app (so it's compatible with v0.28), I have this:

$ git status
On branch backport/0.28/fix-admin-language-selector-12709
nothing to commit, working tree clean
$ bin/rspec decidim-admin/spec/system/admin_manages_more_locales_spec.rb

Randomized with seed 21528

Admin language selector
[DECIDIM] ChromeDriver Workaround is being active: Setting window size to 1920x1080.
  with less than 5 fields
    displays Finnish fields
    displays Romanian fields
  with more than 5 fields
    displays Finnish fields
    displays Romanian fields

Top 4 slowest examples (13.42 seconds, 24.6% of total time):
  Admin language selector with less than 5 fields displays Finnish fields
    4.64 seconds ./spec/system/admin_manages_more_locales_spec.rb:45
  Admin language selector with more than 5 fields displays Finnish fields
    3.87 seconds ./spec/system/admin_manages_more_locales_spec.rb:68
  Admin language selector with more than 5 fields displays Romanian fields
    3.86 seconds ./spec/system/admin_manages_more_locales_spec.rb:62
  Admin language selector with less than 5 fields displays Romanian fields
    1.04 seconds ./spec/system/admin_manages_more_locales_spec.rb:37

Finished in 54.57 seconds (files took 3.85 seconds to load)
4 examples, 0 failures

Randomized with seed 21528

And if I create a development_app compatible with v0.28 and configure more locales in the app and in the organization, then I can't see the original bug here:

So, I'm a bit lost what may be happening in the pipeline. I tried merging against latest commits from v0.28 but that doesn't seem to do anything neither:

$ git pull origin release/0.28-stable
From github.com:decidim/decidim
 * branch                  release/0.28-stable -> FETCH_HEAD
Current branch backport/0.28/fix-admin-language-selector-12709 is up to date.

So, if you can give this a look to see what I'm missing, I'd appreciate it.

[alecslupu]

@andreslucena we have a tricky one ... You opened this PR, and i have fixed it ... so we both have code here... Could you finish the review, since this fix was developed by me in the first place ?

[andreslucena]

LGTM 👍🏽 ✅

(I can´t explicitly approve this as "Pull requests authors can´t approve their own pull request")

[andreslucena]

Great fix @alecslupu

I still not fully understand why this is passing in develop. Probably rails versions differences in how it manages I18n, right?

Merging with the codecov expected failure.