Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more accurate RSS high water mark measurement for Linux #10177

Merged
merged 4 commits into from
May 21, 2024

Conversation

peterallenwebb
Copy link
Contributor

@peterallenwebb peterallenwebb commented May 19, 2024

resolves #10120

Problem

Memory measurement on Linux reflected the maximum RSS level of not just the current process, but all parent processes.

Solution

Measure max RSS on Linux via a platform-specific mechanism that does not have this defect.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@cla-bot cla-bot bot added the cla:yes label May 19, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

Copy link

codecov bot commented May 19, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 88.57%. Comparing base (341803d) to head (75d296b).

Files Patch % Lines
core/dbt/utils.py 72.72% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10177      +/-   ##
==========================================
- Coverage   88.65%   88.57%   -0.08%     
==========================================
  Files         180      180              
  Lines       22422    22434      +12     
==========================================
- Hits        19879    19872       -7     
- Misses       2543     2562      +19     
Flag Coverage Δ
integration 85.97% <75.00%> (-0.17%) ⬇️
unit 63.00% <75.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peterallenwebb peterallenwebb marked this pull request as ready for review May 19, 2024 20:06
@peterallenwebb peterallenwebb requested a review from a team as a code owner May 19, 2024 20:06
Copy link
Member

@aranke aranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, can be cleaned up a little

core/dbt/utils.py Outdated Show resolved Hide resolved
core/dbt/cli/requires.py Outdated Show resolved Hide resolved
@peterallenwebb peterallenwebb merged commit 0d297c2 into main May 21, 2024
63 checks passed
@peterallenwebb peterallenwebb deleted the paw/accurate-linux-rss branch May 21, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Memory Usage Reporting More Reliable
2 participants