dbeaver/dbeaver#22103 replace autosave focus listener with dispose & tabbing support for datetime #22788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Mac issue : if the cell is in edit mode and open any application or editor over the app, it becomes full screen 2024-02-13.14.56.04.mov |
|
value panel is not refreshed |
|
This case is broken again #10561 |
#22103-use-dispose-listener-for-autosave- Fixed focus for combo controls
|
#10561 broken on linux |
|
verified |
serge-rider
requested changes
Apr 1, 2024
| @@ -370,6 +374,9 @@ public void handleEvent(final Event event) { | |||
| // we don't want to mess current grid state | |||
| UIUtils.asyncExec(() -> presentation.navigateLink((GridCell) event.data, event.stateMask)); | |||
| break; | |||
| case SWT.MouseExit: | |||
| System.out.println("Spreadsheet.handleEvent()"); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #22103
Removes hacky way of autosaving for Linux, so it should be tested #10561
Needs to be tested on MacOS and Linux
Focus listener is unfortunately not viable for supporting traverse inside the multi control composites, so it was replaced with dispose listener.
Test that all values save properly after inline editing