dbeaver/dbeaver#20602 load controls for extra pages #22616
+66
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Destrolaric
force-pushed
the
dbeaver/dbeaver#20602-load-controls-for-extra-pages
branch
from
bf8a6f9
to
782a9e9
Compare
serjiokov
reviewed
Jan 30, 2024
...g.jkiss.dbeaver.core/src/org/jkiss/dbeaver/ui/dialogs/connection/ConnectionPageSettings.java
Show resolved
Hide resolved
E1izabeth
reviewed
Feb 1, 2024
| @@ -28,4 +28,17 @@ public interface IDialogPageProvider { | |||
| @Nullable | |||
| IDialogPage[] getDialogPages(boolean extrasOnly, boolean forceCreate); | |||
|
|
|||
| /** | |||
| * Pages what should be saved during creation, even if they were | |||
There was a problem hiding this comment.
Suggested change
| * Pages what should be saved during creation, even if they were | |
| * Pages that should be saved during creation, even if they were |
| * null if no additional pages should be created. | ||
| */ | ||
| @Nullable | ||
| default IDialogPage[] getRequiredDialogPages() { |
There was a problem hiding this comment.
Method name is not descriptive enough. I couldn't understand what does it mean, until I read the comment. I'd propose something like getPagesContainingSettings. Maybe you can figure out better name, but don't left just as is, please. It's not clear what does Required means - required for what?
| @@ -192,6 +191,31 @@ public void activatePage() { | |||
| //getContainer().updateTitleBar(); | |||
| } | |||
|
|
|||
| private void createAdditionalRequiredPages() { | |||
There was a problem hiding this comment.
I doubt about calling this method create... I would rather expact to call it like load.. or smth like that. Yes, you call createControl method, but the control is not visible and so on..
ShadelessFox
reviewed
Feb 1, 2024
E1izabeth
requested review from
serge-rider
and removed request for
LonwoLonwo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now control for extra pages for Oracle and Postgre are loaded during main page initialization which should allow properties to be saved even if no page were loaded previously
Closes #20602