Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add route optimized option to model serving terraform #3572

Merged
merged 1 commit into from
May 22, 2024

Conversation

arjundc-db
Copy link
Contributor

@arjundc-db arjundc-db commented May 14, 2024

Changes

See title
not really worked with terraform so basing this PR off https://github.com/databricks/terraform-provider-databricks/pull/2579/files

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • relevant acceptance tests are passing
  • using Go SDK

@arjundc-db arjundc-db requested review from a team as code owners May 14, 2024 00:47
@arjundc-db arjundc-db requested review from mgyucht and removed request for a team May 14, 2024 00:47
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.56%. Comparing base (acb3700) to head (606bc2c).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3572      +/-   ##
==========================================
+ Coverage   82.55%   82.56%   +0.01%     
==========================================
  Files         184      184              
  Lines       19077    19077              
==========================================
+ Hits        15749    15751       +2     
+ Misses       2405     2404       -1     
+ Partials      923      922       -1     

see 1 file with indirect coverage changes

Copy link
Contributor

@alexott alexott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not merged into Go SDK yet, so we should wait until it's propagated...

@alexott alexott added this pull request to the merge queue May 22, 2024
Merged via the queue into databricks:main with commit 77ccdd6 May 22, 2024
5 checks passed
hectorcast-db added a commit that referenced this pull request May 23, 2024
### New Features and Improvements

 * Fix bug in collectionToMaps ([#3581](#3581)).
 * Added `databricks_enhanced_security_monitoring_workspace_setting ` resource for ESC (Enhanced Compliance and Security) settings ([#3563](#3563)).
 * Added `databricks_automatic_cluster_update_workspace_setting` resource ([#3444](#3444)).
 * Add databricks_compliance_security_profile_workspace_setting resource ([#3564](#3564)).
 * Make customizable error logs more readable ([#3583](#3583)).
 * Fix control run state failures for `databricks_job` resource ([#3585](#3585)).
 * Added support for popular column types for `resource_sql_table` ([#3528](#3528)).
 * Modify state upgrader to remove `ebs_volume_iops` set to zero ([#3601](#3601)).
 * Add route optimized option to model serving terraform ([#3572](#3572)).
 * Rename lakehouse monitor to quality monitor ([#3584](#3584)).

### Documentation Changes
 * Fix documentation for `databricks_storage_credential` and `databricks_external_location` data sources ([#3588](#3588)).

### Exporter
 * Add support for `databricks_mws_permission_assignment` resource ([#3562](#3562)).
 * Don't list directories in the incremental mode ([#3569](#3569)).

### Internal Changes
 * Add TestMwsAccServicePrincipalResourceOnAws to flaky tests ([#3580](#3580)).

### Dependency updates
 * Bump github.com/databricks/databricks-sdk-go from 0.40.1 to 0.41.0 ([#3604](#3604)).
 * Bump github.com/hashicorp/terraform-plugin-sdk/v2 from 2.33.0 to 2.34.0 ([#3594](#3594)).
@hectorcast-db hectorcast-db mentioned this pull request May 23, 2024
github-merge-queue bot pushed a commit that referenced this pull request May 23, 2024
* Release v1.45.0

### New Features and Improvements

 * Fix bug in collectionToMaps ([#3581](#3581)).
 * Added `databricks_enhanced_security_monitoring_workspace_setting ` resource for ESC (Enhanced Compliance and Security) settings ([#3563](#3563)).
 * Added `databricks_automatic_cluster_update_workspace_setting` resource ([#3444](#3444)).
 * Add databricks_compliance_security_profile_workspace_setting resource ([#3564](#3564)).
 * Make customizable error logs more readable ([#3583](#3583)).
 * Fix control run state failures for `databricks_job` resource ([#3585](#3585)).
 * Added support for popular column types for `resource_sql_table` ([#3528](#3528)).
 * Modify state upgrader to remove `ebs_volume_iops` set to zero ([#3601](#3601)).
 * Add route optimized option to model serving terraform ([#3572](#3572)).
 * Rename lakehouse monitor to quality monitor ([#3584](#3584)).

### Documentation Changes
 * Fix documentation for `databricks_storage_credential` and `databricks_external_location` data sources ([#3588](#3588)).

### Exporter
 * Add support for `databricks_mws_permission_assignment` resource ([#3562](#3562)).
 * Don't list directories in the incremental mode ([#3569](#3569)).

### Internal Changes
 * Add TestMwsAccServicePrincipalResourceOnAws to flaky tests ([#3580](#3580)).

### Dependency updates
 * Bump github.com/databricks/databricks-sdk-go from 0.40.1 to 0.41.0 ([#3604](#3604)).
 * Bump github.com/hashicorp/terraform-plugin-sdk/v2 from 2.33.0 to 2.34.0 ([#3594](#3594)).

* fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants