Added support for CustomizeDiff for resource_share #3540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanmay-db
commented
May 3, 2024
| if newObject["name"] == objectsListOld[i]["name"] && newObject["data_object_type"] == objectsListOld[i]["data_object_type"] { | ||
| for k := range objectSchemaMap { | ||
| oldFieldVal := objectsListOld[i][k] | ||
| // To Discuss: |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
We are trying to see whether using CustomizeDiff works since using force_new isn't for any object update isn't feasible. This is a followup to the PR: #3529
Please see the highlighted comment below.
This is a great use case for prioritising moving towards using terraform plugin framework (#3510) as we can access config, state and plan easily: https://developer.hashicorp.com/terraform/plugin/framework/handling-data/accessing-values whereas here we would have to use more hacks and it would lead to piling up of technical debt even if we get to have it working somehow.
This situation could occur for other similar resources with lists.
Tests
Integration test
make testrun locallydocs/folderinternal/acceptance