Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Databricks Account Console IP Access Lists #3221

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

nkvuong
Copy link
Contributor

@nkvuong nkvuong commented Feb 6, 2024

Changes

  • Add support for databricks_ip_access_list at account-level
  • Refactor databricks_ip_access_list tests to use Mock

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • relevant acceptance tests are passing
  • using Go SDK

@nkvuong nkvuong requested review from a team as code owners February 6, 2024 12:03
@nkvuong nkvuong requested review from tanmay-db and removed request for a team February 6, 2024 12:03
@nkvuong nkvuong changed the title Add support for Databricks Account Console IP Access Lists #2586 Add support for Databricks Account Console IP Access Lists Feb 6, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2024

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (662a0bd) 83.60% compared to head (bed1350) 83.61%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3221      +/-   ##
==========================================
+ Coverage   83.60%   83.61%   +0.01%     
==========================================
  Files         169      169              
  Lines       15094    15132      +38     
==========================================
+ Hits        12619    12653      +34     
- Misses       1735     1739       +4     
  Partials      740      740              
Files Coverage Δ
access/resource_ip_access_list.go 87.50% <84.12%> (+6.54%) ⬆️

... and 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants