Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ style: Update Messages Style to Match ChatGPT (ChatGPT UI) #2741

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

techwithanirudh
Copy link
Contributor

@techwithanirudh techwithanirudh commented May 16, 2024

Summary

Modernized the message components to match ChatGPT’s style and optimized dark mode support.

Note: ⚠️ This P.R. is one of multiple smaller P.R.s split from a larger one by GPT-4o.

Desktop

Before:
image

After:
image

Before:
image

After:
image

Mobile

Before:
image

After:
image

Before:
image

After:
image

Change Type

  • New feature (non-breaking change which adds functionality)

Testing

N/A

Test Configuration:

N/A

Checklist

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • I have commented in any complex areas of my code
  • My changes do not introduce new warnings
  • Local unit tests pass with my changes

@techwithanirudh techwithanirudh marked this pull request as ready for review May 16, 2024 07:00
@techwithanirudh techwithanirudh changed the title Updating Messages feature with files from new/feat/new-ui ✨ style: Update Messages Style to Match ChatGPT May 16, 2024
@techwithanirudh techwithanirudh changed the title ✨ style: Update Messages Style to Match ChatGPT ✨ style: Update Messages Style to Match ChatGPT (ChatGPT UI) May 16, 2024
@berry-13
Copy link
Collaborator

@techwithanirudh many of my friends don't want to use the new "Chat bubble". Could we create a switch for it? additionally, can we include this "var" in the "edit messages" PR?

techwithanirudh and others added 8 commits May 21, 2024 07:44
Note: This code has not been run and is assumed to work, p2 will check if this implementation works and use the recoil state to make modifcations to the UI
fix: use default value as true for messagesUI
fix: add com_nav_messages_ui for the text for the switch
@techwithanirudh
Copy link
Contributor Author

techwithanirudh commented May 21, 2024

@techwithanirudh many of my friends don't want to use the new "Chat bubble". Could we create a switch for it? additionally, can we include this "var" in the "edit messages" PR?

Once this pull request is merged, I will add the conditional check for the parameter in the EditMessages pull request, but other than that everything is done.

Update: I have updated the EditMessages functionality to respect the flag.

@berry-13
Copy link
Collaborator

@techwithanirudh many of my friends don't want to use the new "Chat bubble". Could we create a switch for it? additionally, can we include this "var" in the "edit messages" PR?

Once this pull request is merged, I will add the conditional check for the parameter in the EditMessages pull request, but other than that everything is done.

thanks!

@danny-avila
Copy link
Owner

danny-avila commented May 27, 2024

@techwithanirudh many of my friends don't want to use the new "Chat bubble". Could we create a switch for it? additionally, can we include this "var" in the "edit messages" PR?

Once this pull request is merged, I will add the conditional check for the parameter in the EditMessages pull request, but other than that everything is done.

@techwithanirudh many of my friends don't want to use the new "Chat bubble". Could we create a switch for it? additionally, can we include this "var" in the "edit messages" PR?

Once this pull request is merged, I will add the conditional check for the parameter in the EditMessages pull request, but other than that everything is done.

@techwithanirudh many of my friends don't want to use the new "Chat bubble". Could we create a switch for it? additionally, can we include this "var" in the "edit messages" PR?

Once this pull request is merged, I will add the conditional check for the parameter in the EditMessages pull request, but other than that everything is done.

I won't be merging this PR or any of the other UI updates unless there is a way to select different themes for the new UI updates, with the current theme being the default.

@techwithanirudh
Copy link
Contributor Author

techwithanirudh commented May 28, 2024

@danny-avila This has already been implemented in this P.R, if this P.R gets merged I could update the others to do the same.

@danny-avila
Copy link
Owner

@danny-avila This has already been implemented in this P.R, if this P.R gets merged I could update the others to do the same.

Ok, I didn't realize that. I will try it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants