Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed zlib dependency for Linux #844

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixed zlib dependency for Linux #844

wants to merge 2 commits into from

Conversation

ypopovych
Copy link

Used the same approach as in SwiftNIO (C target with a linked native library).
If CommonCrypto dependency will be resolved can be compiled on Linux.

rinsuki added a commit to rinsuki/AUEtherCapture that referenced this pull request Mar 4, 2021
rinsuki added a commit to rinsuki/AUEtherCapture that referenced this pull request Mar 6, 2021
* Add Socket.IO Official Client (it might not work in Windows)

* Use patched version of StarScream

daltoniam/Starscream#844

* Use forked version of Starscream

* update dependencies

* update dependencies

* remove socket.io client code

* WIP: support lobby, state, player event

* CI(Linux): Install libcurl-dev package

* CI(Linux): Use libcurl4-openssl-dev insteadof libcurl-dev

* Support gameend event & remove players after gameend/disconnect

* README: ✅ Linked with AutoMuteUs

* Add WindowsCompatibility.swift (sleep)
@danibachar danibachar mentioned this pull request May 11, 2021
@dmiluski
Copy link

Hi folks, seeing if there was any update here?

@SammyAlvarado
Copy link

Sorry to ask but how do you edit the SwiftPM?

@danpalmer
Copy link

@daltoniam hey is there anything blocking this? Can I/we help in getting this merged and released at all?

@raisameneses
Copy link

Is this solution going to be merged ?

@canbalkaya
Copy link

Sorry to ask but how do you edit the SwiftPM?

Hey @SammyAlvarado. In order to edit SPM, you need to take it to the locally.

You can read this article: https://developer.apple.com/documentation/swift_packages/editing_a_package_dependency_as_a_local_package.

@johndpope
Copy link

johndpope commented Sep 4, 2022

please merge.
the branch
Screen Shot 2022-09-04 at 10 18 54 am

the patched version seems broken
Screen Shot 2022-09-04 at 10 19 34 am

gh repo clone daltoniam/Starscream
Cloning into 'Starscream'...
remote: Enumerating objects: 3251, done.
remote: Counting objects: 100% (61/61), done.
remote: Compressing objects: 100% (45/45), done.
remote: Total 3251 (delta 28), reused 29 (delta 14), pack-reused 3190
Receiving objects: 100% (3251/3251), 2.68 MiB | 593.00 KiB/s, done.
Resolving deltas: 100% (1752/1752), done.
(base) ➜ test cd Starscream
(base) ➜ Starscream git:(master) gh pr checkout 844
remote: Enumerating objects: 13, done.
remote: Counting objects: 100% (7/7), done.
remote: Total 13 (delta 7), reused 7 (delta 7), pack-reused 6
Unpacking objects: 100% (13/13), 1.21 KiB | 103.00 KiB/s, done.
From https://github.com/daltoniam/Starscream

  • [new ref] refs/pull/844/head -> tesseract-one/master
    Switched to branch 'tesseract-one/master'

UPDATE
you can merge pr into own fork - or use mine - maybe use exact.

dependencies: [
.package(url: "https://github.com/wweevv-johndpope/Starscream.git", from: "4.0.4-fix")
],

@cemaltuysuz
Copy link

Im using this library with swift Vapor framework and im getting an error about zlip dependency while deploying my application on Heroku. I need your helps guys. @daltoniam @johndpope

Ekran Resmi 2023-11-17 14 17 20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants