fix: public squads integration #3118
Conversation
sshanzel
requested review from
rebelchris,
omBratteng,
capJavert and
nensidosari
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
| extends Pick<UseFeedOptionalParams<T>, 'options'>, | ||
| extends Pick< | ||
| UseFeedOptionalParams<T>, | ||
| 'options' | 'showPublicSquadsEligibility' |
There was a problem hiding this comment.
Wouldn't this be one of the options better?
There was a problem hiding this comment.
I tried that at first, but it was a type from useQuery itself. options?: UseInfiniteQueryOptions<FeedData>
Thought it would be simpler just to add it.
| @@ -34,5 +73,29 @@ export const usePublicSquadRequests = (): UsePublicSquadRequestsResult => { | |||
| return { | |||
There was a problem hiding this comment.
Should we maybe memoize some of these?
There was a problem hiding this comment.
Good point. Most of the values here are stable. I think we can memoize the status so we won't have to instantiate and calculate days all the time.
|
Would love to hear you guys think 👀 cc @rebelchris @nensidosari |
packages/shared/src/components/squads/PublicSquadEligibilityCard.tsx
Outdated
Show resolved
Hide resolved
packages/shared/src/components/squads/PublicSquadEligibilityCard.tsx
Outdated
Show resolved
Hide resolved
| const fourteenDaysAgo = subDays(new Date(), 14); | ||
| const requestDate = new Date(latestRequest.createdAt); | ||
| return fourteenDaysAgo < requestDate | ||
| ? SquadStatus.Rejected | ||
| : SquadStatus.InProgress; | ||
| } |
There was a problem hiding this comment.
Not sure what was discussed on RFC, but why do we do this logic on the frontend, feels like this should be handled on API side?
CC: @capJavert
There was a problem hiding this comment.
This is not going to be used for validation but something we need to display some alert.
Changes
Events
Did you introduce any new tracking events?
Don't forget to update the Analytics Taxonomy sheet
Log the new/changed events below:
Please make sure existing components are not breaking/affected by this PR
Manual Testing
On those affected packages:
Did you test the modified components media queries?
Did you test on actual mobile devices?
MI-336 #done
MI-344 #done
Preview domain
https://mi-336.preview.app.daily.dev