Mi 146 list view - retry #3113
Merged
Mi 146 list view - retry #3113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Milan Freml <kopancek@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
rebelchris
approved these changes
May 21, 2024
Comment on lines
+116
to
+117
| const shouldUseListFeedLayoutOnMobileTablet = | ||
| !isNullOrUndefined(isLaptop) && !isLaptop && isFeedIncludedInListLayout; |
There was a problem hiding this comment.
Weird feels as the !isLaptop would already be enough here.
There was a problem hiding this comment.
Not enough because it's taking the contrary value of what it should take.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial PR was reverted because of an issue in tags and sources page - see commits here for the last changes to fix the issue.
Issue was related to isLaptop not being defined in SSR and resulting to false statement that the env was mobile when it was not. Resolved by not considering isLaptop view evaluation if it is null or undefined
Decision to move on with this PR here
Preview domain
https://mi-146-list-view.preview.app.daily.dev/
Preview domain
https://mi-146-list-view.preview.app.daily.dev