Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: custom feeds #3106

Merged
merged 63 commits into from
May 27, 2024
Merged

feat: custom feeds #3106

merged 63 commits into from
May 27, 2024

Conversation

capJavert
Copy link
Contributor

@capJavert capJavert commented May 15, 2024

Changes

Describe what this PR does

  • Custom feed implementation
  • Add new feed pages and hooks
  • Refactor feed queries and mutations to support feedId

TODO

  • Fix edge case where tags are not removed after feed update
  • Load initial feeds list from boot (to avoid layout shift)
  • Add custom feed UI behind experiment

Events

Did you introduce any new tracking events?
Don't forget to update the Analytics Taxonomy sheet

Log the new/changed events below:

Type event_name value
New start custom feed
New create custom feed target_id: feedId
New update custom feed target_id: feedId
New delete custom feed target_id: feedId
Change any extra: { feed_id }
Change any extra: { feed: custom }

Please make sure existing components are not breaking/affected by this PR

Manual Testing

On those affected packages:

  • Have you done sanity checks in the webapp?
  • Have you done sanity checks in the extension?
  • Does this not break anything in companion?

Did you test the modified components media queries?

  • MobileL (420px)
  • Tablet (656px)
  • Laptop (1020px)

Did you test on actual mobile devices?

  • iOS (Chrome and Safari)
  • Android

AS-283 #done

Preview domain

https://as-283-custom-feeds.preview.app.daily.dev

@capJavert capJavert self-assigned this May 15, 2024
Copy link

vercel bot commented May 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
daily-webapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 27, 2024 9:30am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
storybook ⬜️ Ignored (Inspect) May 27, 2024 9:30am

@capJavert capJavert changed the title feat: initial frontend feat: custom feeds May 15, 2024
Copy link
Contributor

@nensidosari nensidosari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great in my side as well!

@capJavert capJavert enabled auto-merge (squash) May 27, 2024 09:27
@capJavert capJavert merged commit f40026f into main May 27, 2024
10 checks passed
@capJavert capJavert deleted the AS-283-custom-feeds branch May 27, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants