-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GHA: add MSYS, mingw-w64, Cygwin jobs #13599
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Runs OK now, has OpenSSL + libpsl (plus a bunch of others it detected automaticall). Tests pass.
¹ https://ci.appveyor.com/project/curlorg/curl/builds/49794352 edit: Is the 'no proxy' variant adding much value to be worth keeping it? Or perhaps more variation could be introduced to make it valuable? edit: added parallel test results. (#13609) |
4a1bc58
to
b553c13
Compare
62a789e
to
cb2025f
Compare
``` TESTFAIL: These test cases failed: 1450 1452 ``` https://github.com/curl/curl/actions/runs/9130871594/job/25108803192#step:9:3706 Both timeouts after 2 seconds waiting for the server
This reverts commit c87daed. Still getting: ``` RUN: failed to start the HTTP/2 server test 0358 SKIPPED: failed starting HTTP/2 server ``` https://github.com/curl/curl/actions/runs/9131355420/job/25110379148#step:14:843
``` TESTFAIL: These test cases failed: 2301 2305 ``` Ref: https://github.com/curl/curl/actions/runs/9133227792/job/25116241601#step:14:18246
WebSocket: ``` TESTFAIL: These test cases failed: 2305 ``` Ref: https://github.com/curl/curl/actions/runs/9133449443/job/25116951463#step:14:14502
Last minute I enabled WebSockets in the mingw-w64 job and 2301 and 2305 started failing right away: It's also the first time WebSocket is tested on native Windows in CI. Ignoring these results for now as a workaround. |
WebSockets: ``` TESTFAIL: These test cases failed: 2302 ``` Ref: https://github.com/curl/curl/actions/runs/9139155361/job/25131144383?pr=13689#step:14:9892 Follow-up to 36fd2dd curl#13599 Closes #xxxxx
WebSockets: ``` TESTFAIL: These test cases failed: 2302 ``` Ref: https://github.com/curl/curl/actions/runs/9139155361/job/25131144383?pr=13689#step:14:9892 Follow-up to 36fd2dd #13599 Ref: #13692 Closes #13696
MQTT / OmniOS: ``` TESTFAIL: These test cases failed: 1190 1198 3017 ``` Ref: https://github.com/curl/curl/actions/runs/9258522297/job/25468730731?pr=13694#step:3:10251 MQTT / OmniOS: ``` TESTFAIL: These test cases failed: 1194 2200 2203 2205 ``` Ref: https://github.com/curl/curl/actions/runs/9150523540/job/25155409832#step:3:10233 FTP / OmniOS: ``` TESTFAIL: These test cases failed: 1096 ``` Ref: https://github.com/curl/curl/actions/runs/9150702711/job/25155793948#step:3:10247 FTP / OmniOS: ``` TESTFAIL: These test cases failed: 381 ``` Ref: https://github.com/curl/curl/actions/runs/9163863822/job/25193897640#step:3:10230 FTP / OmniOS: ``` TESTFAIL: These test cases failed: 340 ``` Ref: https://github.com/curl/curl/actions/runs/9233804752/job/25406671742?pr=13771#step:3:10245 Ref: #13583 (comment)
Shot in the dark trying to find out which tests are hanging / going to an infinite loop. The ones failing after 45 minutes (mingw-w64) or 30 minutes (MSVC). Ref: #13599 (comment)
Following up on previous occurrences showing up as gcc warnings, replace the remaining few `time(&var)` calls with `= time(NULL)`, though these aren't specifically causing compiler warnings. All of these are in the TFTP client code (`lib/tftp.c`), except one which is in a debug branch in `lib/http_aws_sigv4`. What's unexplainable is that this patch seems to stabilize the TFTP tests regularly hanging or going into an infinite loop on GHA windows workflows with MSYS2, mingw-w64 and MSVC (Cygwin is unaffected): curl#13599 (comment) I figure it's something worth trying even if it turns out to be a dead end. `time()` docs: https://learn.microsoft.com/en-us/cpp/c-runtime-library/reference/time-time32-time64 https://manpages.debian.org/bookworm/manpages-dev/time.2.en.html Follow-up to 58ca0a2 curl#13800 Follow-up to d0728c9 curl#13643 Closes #xxxxx
Following up on previous occurrences showing up as gcc warnings, replace the remaining `time(&var)` calls with `var = time(NULL)`, though these aren't specifically causing compiler warnings. These are in the TFTP client code (`lib/tftp.c`), except one which is in a debug branch in `lib/http_aws_sigv4.c`. What's unexplainable is that this patch seems to mitigate TFTP tests often hanging or going into an infinite loop on GHA windows workflows with MSYS2, mingw-w64 and MSVC (Cygwin is unaffected): #13599 (comment) TFTP hangs did not entirely disappear though, so could be unrelated. `time()` docs: https://learn.microsoft.com/en-us/cpp/c-runtime-library/reference/time-time32-time64 https://manpages.debian.org/bookworm/manpages-dev/time.2.en.html Follow-up to 58ca0a2 #13800 Follow-up to d0728c9 #13643 Closes #13815
Now build with SSL and PSL to improve test coverage.
CMake, mingw-w64, gcc 13, Debug, x64, Schannel, Static, Unicode
-j14
parallelism when running tests.These jobs offer better performance, more flexibility and
parallelization compared to the AppVeyor ones they replace. It also
offloads AppVeyor, allowing to iterate faster. They also appear more
reliable than e.g. Azure Windows jobs, where runners are prone to fail
1.
Closes #13599
Release
CMake configuration.Footnotes
Exit code 143 returned from process: file name 'C:\Windows\system32\docker.EXE', arguments 'exec -i 6b13a669c6dfe7fb9f59414369872fd64d61c7182f880c3d39c135cb4c115c8f C:\__a\externals\node\bin\node.exe C:\__w\_temp\containerHandlerInvoker.js'.
↩