Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the script to support installing multiple Flarum extensions in one command. #106

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

DoyoDia
Copy link

@DoyoDia DoyoDia commented Mar 24, 2024

While migrating from a direct installation to your Docker version, I faced several issues, one being the incorrect migration of plugins. I resolved this by reinstalling them, requiring a script to install over seventy plugins. Recently, I discovered that modifying the script could expedite this process. Therefore, I had ChatGPT modify the code to support processing multiple package names simultaneously.

Updated the script to support installing multiple Flarum extensions in one command.
@DoyoDia DoyoDia requested a review from crazy-max as a code owner March 24, 2024 05:58
Copy link
Owner

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nits to fix otherwise looks good, thanks!

Also need to update the README:

docker-flarum/README.md

Lines 191 to 195 in a32f450

`docker compose exec flarum extension require <package>`
To remove an extension:
`docker compose exec flarum extension remove <package>`

Can you squash your commits as well when fixed please?

rootfs/usr/local/bin/extension Outdated Show resolved Hide resolved
rootfs/usr/local/bin/extension Outdated Show resolved Hide resolved
DoyoDia and others added 5 commits May 2, 2024 10:38
Co-authored-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Update CHANGELOG

Update extension

Updated the script to support installing multiple Flarum extensions in one command.

Apply suggestions from code review

Co-authored-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>

new year

update README

update README

Flarum 1.8.5

Update CHANGELOG

update readme.md
@DoyoDia
Copy link
Author

DoyoDia commented May 2, 2024

I'm relatively new to Git and have done my best to follow the online guide in this pull request. However, if there are any inaccuracies or issues, please feel free to make adjustments or guide me on how to correct them. I appreciate your understanding and help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants