Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix --list-courses authentication #824

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

holocronweaver
Copy link

@holocronweaver holocronweaver commented May 26, 2022

馃毃Please review the guidelines for contributing to this repository.

Proposed changes

Fixes --list-courses command failing authorization by making use of cauth when available.

I am opening this PR on behalf of the original author @zorone in hopes it can be a quick fix. Happy to open my own PR if additional changes are needed before merge.

Should fix #773 .

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask. We're here
to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING doc
  • I agree to contribute my changes under the project's LICENSE
  • I have checked that the unit tests pass locally with my changes
  • I have checked the style of the new code (lint/pep).
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Reviewers

If you know the person who can review your code please add a @mention.

Add case for add seesion when it get from user. (I think someone who wrote previous code are forgot to add to list_course function too.
Add case for add seesion when it get from user. (I think someone who wrote previous code are forgot to add to list_course function too.
@holocronweaver holocronweaver changed the title Fix Fix --list-courses authentication May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

400 Client Error: while using --list-courses
3 participants