Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix#778 - HTMLParser.unescape was removed from Python since version 3.9.0a1 #782

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Kirija
Copy link

@Kirija Kirija commented Oct 30, 2020

…ause deprecated

🚨Please review the guidelines for contributing to this repository.

Proposed changes

HTMLParser.unescape was deprecated and removed from Python since version 3.9.0a1
So i just use html.unescape() instead of the original HTMLParser.unescape()

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • [x ] Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask. We're here
to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING doc
  • [x ] I agree to contribute my changes under the project's LICENSE
  • I have checked that the unit tests pass locally with my changes
  • I have checked the style of the new code (lint/pep).
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, please explain why you chose
the solution you did and what alternatives you considered, etc.

Reviewers

If you know the person who can review your code please add a @mention.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 73.249% when pulling ecfc821 on Kirija:master into f9a9a26 on coursera-dl:master.

@heino
Copy link

heino commented Dec 27, 2020

Duplicate of #789,

which also catches the issue futrher down the file, and preserves backward compatiblity.

@erensunerr
Copy link

Hey! Please merge this fix. I had to fix it by hand while using it today 😭.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants