Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: split out dev apt dependencies #32475

Closed
wants to merge 0 commits into from

Conversation

BBBmau
Copy link
Contributor

@BBBmau BBBmau commented May 19, 2024

Fixes #32470

Draft is for set up of both interactive and non-interactive flows. PR will be ready when the dependencies are properly split apart

output for installing extra dependencies: no
Screenshot from 2024-05-18 20-27-08

output for installing extra dependencies: yes
Screenshot from 2024-05-18 20-27-21

non-interactive - we set the env variable ALL_PKGS to tell bash ahead of time our response to the prompt
Screenshot from 2024-05-18 20-45-54

Copy link
Contributor

github-actions bot commented May 19, 2024

Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • the change is something we merge
    • include a route or your device' dongle ID if relevant

@BBBmau
Copy link
Contributor Author

BBBmau commented May 19, 2024

previous failures were due to not having. commaai/cereal#611

Checks will pass but deps still need to be split properly.

@BBBmau BBBmau marked this pull request as ready for review May 20, 2024 21:09
@BBBmau
Copy link
Contributor Author

BBBmau commented May 20, 2024

Ready for review: I went through each pkgs running apt-cache show <PKG> to get the description so i could best judge whether or not it's an optional package or not. 3 stood out as ones where we might not need from the description provided from apt-cache show but I still included it. This is all just based ony my judgement so I would definitely need more input on the packages marked as optional, the following are what i set as optional with (?) as whether or not we actually even need this in the first place:

clinfo
portaudio19-dev
libqt5sql5-sqlite
libqt5charts5-dev
libreadline-dev
libdw1
libbz2-dev
autoconf
build-essential (?)
libtool
bzip2
libarchive-dev
libncurses5-dev (?)
libncursesw5-dev (?)
libportaudio2 
libsqlite3-dev
locales 

@adeebshihadeh
Copy link
Contributor

Went with #32476 since it was a bit simpler. We'll still pay out the $100 if you want to rebase this and move over every dependency that isn't necessary for building openpilot and running the tests in CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[$100 bounty] tools: split out dev apt dependencies
2 participants