Fingerprint: 2024 Honda Civic Bosch Hatch #32474
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:
|
sshane
reviewed
May 19, 2024
Comment on lines
+43
to
+49
| if CP.transmissionType != TransmissionType.manual: | ||
| if CP.carFingerprint in (CAR.CRV_HYBRID, CAR.CIVIC_BOSCH_DIESEL, CAR.ACURA_RDX_3G, CAR.HONDA_E, CAR.HONDA_CIVIC): | ||
| messages.append((gearbox_msg, 50)) | ||
| else: | ||
| messages.append((gearbox_msg, 100)) | ||
| else: | ||
| messages.append((gearbox_msg, 100)) | ||
| messages.append(("GAS_PEDAL_2", 100)) |
There was a problem hiding this comment.
What's with the manual transmission changes?
|
Looks like we already fuzzy match the Civic 2024: #32501, so this port is for the manual/Type R version. We don't currently have any plans of supporting any manual Hondas at this moment, plus this PR appears to not work as intended. Closing for now. Feel free to get this working on your own fork. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2024 Honda Civic Bosch Hatch car port
Route: 92e1b57c4ef919b7/00000008--4647b2b06f