remove unittest test_models #32465
Closed
remove unittest test_models #32465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:
|
|
skips base class tests but so does |
adeebshihadeh
requested changes
May 18, 2024
Comment on lines
+14
to
+16
| route_or_segment_name = SegmentName(route, allow_route_name=True) | ||
| segment_num = route_or_segment_name.segment_num if route_or_segment_name.segment_num != -1 else None | ||
| test_route = CarTestRoute(route_or_segment_name.route_name.canonical_name, car, segment=segment_num) |
There was a problem hiding this comment.
all this stuff runs at import time now. it should only be run if we're running this script
| from openpilot.tools.lib.route import SegmentName | ||
|
|
||
| route = os.getenv('ROUTE') |
There was a problem hiding this comment.
this is now harder to use without the argparser. can we bring that back?
|
@adeebshihadeh because of pytest discovery, lose something similar to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
openpilot.selfdrive.car.tests.test_models.pytools/car_porting/test_car_model.pyto inherit fromtest_models.pynot totally ideal but keeps use