Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: add elasticsearch retriever #115

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Justicea83
Copy link
Contributor

@Justicea83 Justicea83 commented May 8, 2024

Thank you for contributing to the Cohere Toolkit!

  • PR title: "Add search to ELK cluster"

    • Add changes to add search from ELK stack
    • Example: "deployment: Cohere Platform"
  • PR message: Delete this entire checklist and replace with

    • Description: Add Elasticsearch retriever
    • Dependencies: elasticsearch
Screenshot 2024-05-08 at 04 58 45 Screenshot 2024-05-08 at 04 59 34

@Justicea83 Justicea83 changed the title Add elasticseearch tools: add elasticsearch retriever May 8, 2024
@Justicea83 Justicea83 marked this pull request as ready for review May 8, 2024 08:56
@Justicea83 Justicea83 requested a review from a team as a code owner May 8, 2024 08:56
@Justicea83
Copy link
Contributor Author

@tianjing-li tagging you because this is a new version of the previously closed PR here

Copy link
Collaborator

@tianjing-li tianjing-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change then good to go, you'll also need to sign all your previous commits.

You can setup a GPG key (see the readme) and then run the following:

git reset $(git merge-base main $(git branch --show-current))
^it undos all your commits and adds it to you local changes
then
git commit -S -m "your message"
git push --force

@Justicea83
Copy link
Contributor Author

Bumping for reviews

@@ -1,4 +1,4 @@
import { DEFAULT_CHAT_TOOL } from '@/cohere-client';
import {DEFAULT_CHAT_TOOL, DEFAULT_ELASTIC_SEARCH_TOOL} from '@/cohere-client';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind removing the FE changes? Since the community features are not required to run the toolkit, this could lead to errors or confusing UX.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants