-
Notifications
You must be signed in to change notification settings - Fork 677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dgram
crate
#1764
Draft
evanrittenhouse
wants to merge
26
commits into
master
Choose a base branch
from
evanrittenhouse/dgram
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Add dgram
crate
#1764
+888
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanrittenhouse
force-pushed
the
evanrittenhouse/dgram
branch
8 times, most recently
from
April 24, 2024 14:56
9ad7cc5
to
6f1c5dd
Compare
evanrittenhouse
force-pushed
the
evanrittenhouse/dgram
branch
9 times, most recently
from
May 2, 2024 14:08
8ea3dd9
to
cc10a34
Compare
evanrittenhouse
force-pushed
the
evanrittenhouse/dgram
branch
from
May 10, 2024 23:47
1b4ed63
to
e8b6134
Compare
evanrittenhouse
force-pushed
the
evanrittenhouse/dgram
branch
from
June 7, 2024 17:13
284b0b9
to
678093f
Compare
1) Remove Mio layer and replace it with a sync FD layer 2) Move RecvData, RecvMetrics, and StoreCmsgSettings to `lib`, since syscalls is private 3) Rework the signature of `recv_msg` to take a `StoreCmsgSettings` to allow applications to handle custom cmsgs
evanrittenhouse
force-pushed
the
evanrittenhouse/dgram
branch
from
June 11, 2024 17:07
678093f
to
f0620a7
Compare
evanrittenhouse
force-pushed
the
evanrittenhouse/dgram
branch
from
June 12, 2024 00:39
f0620a7
to
5003df3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds a new crate for abstracting away direct interactions with cmsgs. It currently only contains implementations for Linux, but we can add multi-platform support when required.
Tasks
quiche/apps/sendto
master
as a control groupasync
Testing
Unit tests exist for basic functionality, but should probably be more robust.
To check the actual GSO/GRO syscall counts, I'm using
quiche-server
andquiche-client
. The general test plan is to make 30 requests toquiche-server
, returning a 1MB body each time to trigger batching (e.g. modifying theNot Found!
response). I used the following command to grab the syscall counts:and for sending the requests:
The syscall counts are as follows:
Server
No GSO/GRO
GSO/GRO
And on master, as a control:
No GSO
GSO